[vlc-devel] [PATCH 00/14] Move VLM implementation to a module

Romain Vimont rom1v at videolabs.io
Wed Sep 16 10:23:50 CEST 2020


Hi Rémi,

On Tue, Sep 15, 2020 at 09:10:16PM +0300, Rémi Denis-Courmont wrote:
> Le tiistaina 15. syyskuuta 2020, 20.37.32 EEST Romain Vimont a écrit :
> > This removes a lot of VLM code (including parsing) from libvlccore.
> 
> What is the actual point of this?

The idea was to lighten and simplify libvlc core (the complexity being
moved to the VLM module), and not load the VLM code in memory when VLM
is not used (which is often the case).

> There is no point defining a module type if it does not save any dependencies 
> within the core and there is only one single implementation.

I acknowledge that the justifications to move it to a module would be
stronger if it saved dependencies within the core or if there were
several implementations.

> You're just 
> making things more complicated by adding more boilerplate code and possibly 
> exporting more functions.

In fact, it exports less functions (vlm_Control and vlm_ExecuteCommand
are removed).

I would prefer to also remove all other vlm_* functions from the core
(so that modules using VLM would communicate directly with the VLM
module), but it's not clear how to do that properly (several users of
VLM should still get the same instance). Cf mail from Alexandre:
https://mailman.videolan.org/pipermail/vlc-devel/2020-September/137514.html

Granted, it adds vlc_cond_timedwait_daytime(), but all vlc_cond_*()
functions were already exposed, that was the only exception (I get that
there are reasons to remove this function, but IMO this is another
debate).

> It won't even save memory in the case that VLM is
> not used, since it wouldn't be paged-in either way.

Hmm, I don't know.

Regards

> In fact, in this case, vlc_cond_timedwait_daytime() does not even work 
> correctly except on Linux. So unless you're going to actually fix it, you'd 
> expose it less (remove it) than more.
> 
> Converting VLM or parts of it into an interface module? Fixing bugs? Removing 
> useless code? great. Adding a new module type? no thanks.
> 
> -- 
> Реми Дёни-Курмон
> http://www.remlab.net/
> 
> 
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel


More information about the vlc-devel mailing list