[vlc-devel] [PATCH v2 07/11] qt: postpone the creation of the systray

[Pierre Lamot]

On 2020-09-16 10:15, Thomas Guillem wrote:
> On Wed, Sep 16, 2020, at 09:24, Pierre Lamot wrote:
>>   This speedup the application startup as the systray creation is done
>>   synchronously.
> 
> You mean asynchronously ?

I meant that it was executed synchronously and taking a noticeable 
amount of time.
this patch postpone the creation do it doesn't block the Open of the 
module.

I tend to describe the issue using present tense. maybe this would be 
more clear using past tense

> 
> 
>> ---
>>  modules/gui/qt/maininterface/main_interface.cpp | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>> 
>> diff --git a/modules/gui/qt/maininterface/main_interface.cpp
>> b/modules/gui/qt/maininterface/main_interface.cpp
>> index 69ef7bb40b..8e4d2f7baf 100644
>> --- a/modules/gui/qt/maininterface/main_interface.cpp
>> +++ b/modules/gui/qt/maininterface/main_interface.cpp
>> @@ -166,7 +166,8 @@ MainInterface::MainInterface(intf_thread_t 
>> *_p_intf
>> , QWidget* parent, Qt::Windo
>>      /*********************************
>>       * Create the Systray Management *
>>       *********************************/
>> -    initSystray();
>> +    //postpone systray initialisation to speedup starting time
>> +    QMetaObject::invokeMethod(this, &MainInterface::initSystray,
>> Qt::QueuedConnection);
>> 
>>      /*************************************************************
>>       * Connect the input manager to the GUI elements it manages  *
>> --
>> 2.25.1
>> 
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel