[vlc-devel] [PATCH] fix null deref crash

[Lyndon Brown]

a few plugins have recently introduced options with no shorttext,
resulting in a null dereference crash when their respective entries are
selected in the Qt advances prefs tree.

the Qt prefs code reasonably expects all options to have shorttext,
which they all have until recently. i have patches to address the
missing text in two of them, while the third is in a mock plugin where
it doesn't really matter.

the Qt code is passing the property down to vlc_gettext/vlc_ngettext
functions, which is where the crash occurs. these functions dereference
the string in order to avoid wasting time on empty strings. however
they fail to first check that the pointer is not null, thus crash in
such situations.

while all options should have shorttext labels, it's not great that the
translation functions cannot cope with a null pointer.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: textdomain_nd.patch
Type: text/x-patch
Size: 1909 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20200917/c9a0d538/attachment.bin>