[vlc-devel] [PATCH 01/22] picture: add helpers for picture chaining

[Steve Lhomme]

On 2020-09-17 19:16, Rémi Denis-Courmont wrote:
> Le torstaina 17. syyskuuta 2020, 18.33.23 EEST Steve Lhomme a écrit :
>> Picture chains are used either to keep a list of picture (in FIFO order) or
>> to attach a picture to another (filters).
> 
> TBH, singly-listed are so trivial in C that I tend to be happy just hand-
> coding them. Not that I really care either way.

If you look at the patches you'll see that in many cases the code was 
hard to decypher. In some cases because double pointers were used (and 
the same pattern used in various places). The mnemonics are also 
inconsistent, the order to do things also inconsistent.

I don't doubt that the code worked, that doesn't make it easy to read or 
maintain.

Also my original goal was to try to use vlc_list instead of p_next. But 
to do that properly it's better to start of clear basis. In the end I 
don't know if it's worth the transition but I got clearer/cleaner code 
for free.

> For comparison, the queue API and the long-standing block FIFO are more about
> thread-safety than singly listing.
> 
> -- 
> 雷米‧德尼-库尔蒙
> http://www.remlab.net/
> 
> 
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
>