[vlc-devel] [PATCH] player: input: Store tracks presence in the ml struct

[Thomas Guillem]

LGTM

On Thu, Sep 17, 2020, at 21:10, Rémi Denis-Courmont wrote:
> Le torstaina 17. syyskuuta 2020, 21.31.09 EEST Alexandre Janniaux a écrit :
> > It could be suggested to use no if condition for that:
> > 
> >         input->ml.has_video_tracks |= !input->ml.has_video_tracks
> >                                    && ev->fmt->i_cat == VIDEO_ES;
> >         input->ml.has_audio_tracks |= !input->ml.has_audio_tracks
> >                                    && ev->fmt->i_cat == AUDIO_ES)
> 
> This is using the *bit-wise* disjunction operator for what is semantically a 
> *logical* disjunction. It works, but I can't say that it would be particularly 
> pretty.
> 
> -- 
> 雷米‧德尼-库尔蒙
> http://www.remlab.net/
> 
> 
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel