[vlc-devel] [PATCH] esformat/transform work resubmission

[Lyndon Brown]

Okay, I'll perhaps do that. Thanks :)

On Sat, 2020-09-19 at 00:01 +0200, Alexandre Janniaux wrote:
> Hi,
> 
> Don't bother, just send me branch privately and I'll convert
> into patches on the mailing list if needed if you prefer.
> 
> Regards,
> --
> Alexandre Janniaux
> Videolabs
> 
> On Fri, Sep 18, 2020 at 09:48:55PM +0100, Lyndon Brown wrote:
> > On Fri, 2020-09-18 at 22:58 +0300, Rémi Denis-Courmont wrote:
> > > Le perjantaina 18. syyskuuta 2020, 22.38.44 EEST Alexandre
> > > Janniaux a
> > > écrit :
> > > > To be honest, I don't think that's your fault or that you need
> > > > to justify yourself. Some developers here prefers mail patches,
> > > > others attached patches for ease of download, and others prefer
> > > > git branches.
> > > 
> > > People will probably never agree whether email or web-based MR
> > > are
> > > better, as
> > > they both have their pros and cons for the purpose of code
> > > review.
> > > 
> > > But patch files or plain branches are just impossible to review.
> > > I
> > > think that
> > > tthey are only suitable for merging. As such, you should never
> > > *start* with
> > > either of those.
> > 
> > How would you feel about the idea of a mixed attach + copy&paste
> > approach?
> > 
> > I.e. at the same time as attaching, pasting a copy into the email
> > (hand
> > crafting a series when multiple, though they might not be threaded
> > correctly, unless perhaps if they are created as replies to the
> > cover
> > email), with a reminder given that the inline copy may not be
> > suitable
> > for merging due to possible wrapping or otherwise.
> > 
> > Initial review can then be done on the inline copy, and the
> > attached
> > copy can be used for the final merge.
> > 
> > It requires a little more work on my end, but manageable in the
> > short
> > term, and with little intention to submit much more before MRs are
> > possible, unless significant further delay.
> > 
> > Would this be more helpful?
> > 
> > _______________________________________________
> > vlc-devel mailing list
> > To unsubscribe or modify your subscription options:
> > https://mailman.videolan.org/listinfo/vlc-devel
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel