[vlc-devel] [PATCH] qt: fix hiding empty groupboxes

[Jean-Baptiste Kempf]

Agreed. Pushed.

On Fri, 18 Sep 2020, at 20:08, Lyndon Brown wrote:
> Maybe. It's a very rare thing to have an empty box though and the fix
> just corrects existing logic hide-based logic rather than trying to re-
> engineer a different delete-based approach. I could look into spending
> a little time trying to change to such an approach, but I'd honestly
> rather not; I've got a lot of other work to press on with and a ton of
> additional Qt preferences work from 2019 to submit, which I might then
> possibly find myself having to rework if I was to change this now. So
> could this please just go in as is.
> 
> On Fri, 2020-09-18 at 10:14 +0200, Pierre Lamot wrote:
> > Maybe the box should be released in this case as it won't be
> > displayed
> > But I guess that's not a strong requirement as the box is well
> > parented, 
> > and will be released when closing the widget.
> > 
> > On 2020-09-17 21:01, Lyndon Brown wrote:
> > > from the commit log:
> > > -----------------------
> > > 
> > > qt: hide all empty groupboxes
> > > 
> > > if a panel only has one groupbox and it is empty, it was hidden,
> > > but
> > > otherwise they were shown; this was surely a bug, and at any rate
> > > is
> > > undesirably messy. all empty groupboxes are now hidden.
> > > 
> > > an example case: this fixes the empty "Performance options"
> > > groupbox
> > > (on my system) under the top-level "Advanced" tree node in the
> > > advanced
> > > preferences view, which happens to be very visible as the first
> > > panel
> > > shown when switching to advanced mode.
> > > 
> > > _______________________________________________
> > > vlc-devel mailing list
> > > To unsubscribe or modify your subscription options:
> > > https://mailman.videolan.org/listinfo/vlc-devel
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel

-- 
Jean-Baptiste Kempf -  President
+33 672 704 734