[vlc-devel] [PATCH v3 00/24] picture::p_next usage cleaning

Steve Lhomme robux4 at ycbcr.xyz
Mon Sep 21 08:51:17 CEST 2020


On 2020-09-21 8:29, Steve Lhomme wrote:
> Changes sinces v2:
> - fix incorrect filter_chain API translation (and it becomes a bit clearer what
>    it's doing)
> - rename picture_chain API's to vlc_picture_chain_XXX with uppercasing
> - uppercase the picture_ API's
> - reorder the new API's in vlc_picture.h
> 
> In the end vlc_picture_chain_Prepend should go away as snapshot could just use
> a FIFO. We can then remove vlc_picture_chain_PopChain() as well which is not
> safe. Even though snapshot uses clones of pictures so don't cary over the
> original picture chaining.

And since it's using a clone, as long as the picture is not exported, it 
keeps it as used. The decoder cannot reuse that picture during that 
time. So it *should* use a FIFO no matter what.


More information about the vlc-devel mailing list