[vlc-devel] [PATCH] video_output: refactor vlc_gl_api into opengl providers

[Alexandre Janniaux]

Hi,

On Mon, Sep 21, 2020 at 01:15:05PM +0200, Thomas Guillem wrote:
> Hello,
>
>
> From what I see, you just moved the vlc_gl_api_Init() call from vout_helper.c to each module. The call was and still is surrounded by ?GLMakeCurrent(). So, I fail to see a difference with this only patch.
>
> Maybe include the patches (or only one) that depends on this one to show us the big picture.

I refer you to the OpenGL Filter RFC I've sent, and the details in the
commit message. ;)

What this patch does is exactly what you're saying. The MakeCurrent
before fetching the symbols is not sexy, but WGL and EGL need it and
in general, it's needed to extract some OpenGL properties.

The point is that with filters, you need to link each gl API providers
with the OpenGL informations, which is very annoying since those are
typically filter_t, display and vout_helper code.

Instead, this patch suggests to use the building block actually called
"OpenGL providers" to provide OpenGL.

I hope this is clearer.

Regards,
--
Alexandre Janniaux
Videolabs