[vlc-devel] [PATCH 4/5] lib: media: copy the input item

[Thomas Guillem]

On Mon, Sep 21, 2020, at 17:14, Rémi Denis-Courmont wrote:
> Le maanantaina 21. syyskuuta 2020, 15.53.58 EEST Thomas Guillem a écrit :
> > In order to avoid having more than one libvlc_media_t using the same
> > input_item_t.
> 
> It's not that innocent. Now those two items will no longer share modifications. 
> This might fix some issues (silently), but more likely, it creates new issues.

Indeed, it's not innocent at all.

> 
> Does it even work for preparsing and friends?

The test suite is happy. Unfortunately, the libvlc test suite is not complete enough to detect regressions for that case.
I will do more tests before applying.

>From what I saw, there 2 significant changes with this patch:
 - You won't be able to receive item update from service discoveries. I can check again, but I think all our SD modules leave the item unchanged after sending them. If it's actually the case, we can enforce it with documentation/asserts.
 - You won't be able to receive item update from readdir access/demux (subitems). This one is quite easy. Indeed, modules are killed after sending their items, so it is very unlikely (impossible?) that such items are updated.

> 
> -- 
> レミ・デニ-クールモン
> http://www.remlab.net/
> 
> 
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel