[vlc-devel] [PATCH v3 01/24] picture: add helpers for picture chaining

[Steve Lhomme]

On 2020-09-21 17:13, Rémi Denis-Courmont wrote:
> Le maanantaina 21. syyskuuta 2020, 11.53.16 EEST Steve Lhomme a écrit :
>>> Do we really need this PopChain ?
>>> You are returning the whole chain and yet you keep it in chain. This feels
>>> dangerous.
> 
> Yeah.
> 
>> For now I'm just moving the existing code into proper API's without
>> changing what they do.
>>
>> As I said in the cover letter, this one should be removed after snapshot
>> uses a proper FIFO.
> 
> I would rather add only proper APIs, and then fix bad uses one by one, than
> introduce temporary naughty APIs, and then replace them with proper APIs.
> 
> But as long as it does not break incremental builds, whatever's already done's
> already done, I guess. I'd add a VLC_DEPRECATED though.

I removed it in v4 to use a FIFO in snapshot. There's only "AppendChain" 
left in v4 that I don't like. This is the filters chaining pictures 
together because they can return many at once or send them one by one. 
I'm working on that.