[vlc-devel] [PATCH 2/4] ytdl: access module for YoutubeDL

[Thomas Guillem]

On Tue, Sep 22, 2020, at 10:19, Thomas Guillem wrote:
> 
> 
> On Tue, Sep 22, 2020, at 07:56, Steve Lhomme wrote:
> > On 2020-09-22 7:50, Steve Lhomme wrote:
> > > On 2020-09-21 18:02, Rémi Denis-Courmont wrote:
> > >> This passes every HTTP(S) URL through YoutubeDL to extract playlists
> > > 
> > > That sounds like a terrible idea. What is the extra time and memory 
> > > consumption added to every HTTP call ?
> > 
> > Other aspect of this, if one wants to add vimeo, dailymotion, tiktok, 
> > twitter, etc. Are we going to add one python layer for each ? Or should 
> > we centralize all these tests in one call ?
> 
> No we will do it in Rust.

Trolling apart, youtube-dl works with vimeo, dailymotion, tiktok. It works with a lot (all?) of video content that can be found on the web. So, we really need ONE module, and it's youtube dl.

I would appreciate a small measurement of time being spent when ytdl is loaded and fails to parse the url.
If it's too slow, what about keeping the ytdl process alive (and waiting for requests) while vlc is alive ?

> 
> > 
> > > Also that means the python script becomes a very sensitive part of VLC. 
> > > Is it going to be fuzzed ? What about the Youtube-DL that users may 
> > > download from questionable locations, since we don't ship it (nor fuzz 
> > > it) ?
> > > 
> > >> or media. If YoutubeDL fails, it falls back to the normal HTTP(S)
> > >> access. This includes if YoutubeDL or Python 3 are not found.
> > _______________________________________________
> > vlc-devel mailing list
> > To unsubscribe or modify your subscription options:
> > https://mailman.videolan.org/listinfo/vlc-devel
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel