[vlc-devel] [PATCH 4/4] ytdl: use redirect for single media

[Alexandre Janniaux]

Hi,

On Mon, Sep 21, 2020 at 11:56:42PM +0200, Pierre Ynard via vlc-devel wrote:
> Date: Mon, 21 Sep 2020 23:56:42 +0200
> From: Pierre Ynard <linkfanel at yahoo.fr>
> To: vlc-devel at videolan.org
> Subject: Re: [vlc-devel] [PATCH 4/4] ytdl: use redirect for single media
> User-Agent: Mutt/1.5.23 (2014-03-12)
>
> > Well you can't have it both ways:
> > - Either we redirect, and there is not going to be any metadata.
> > - Or we use a playlist, and we'll have the URL expiry problem (and major
> >   delay in parsing larger playlists).
>
> Can we, in an access module, first set metadata on the associated input
> item, then reset the URL, and then fail with a redirect? I don't see why
> that fundamentally couldn't work.
>
> > And playing without metadata is surely no worse than failing to play
> > and also to get any metadata, which is the current situation with VLC
> > for most YoutubeDL-supported sites.
>
> Let's aim a little higher with this new design than settling for the
> less worse, shall we?

Can't we wait to merge this before designing new methods to fix the
playlist demux design itself? it seems to me that the discussion would
be better focused on a dedicated thread, especially given that Rémi
did express his desire to not extend the patchset to the core.

The code won't burn the codebase even if it's not perfect. That's the
very goal of writing code in this constraining module system too.

As far as I can test, I can read a whole youtube playlist, store it
somewhere (in the future, save to ML?) with this module so it's doing
its initial job, and there's no point in discussing each and every
possible improvement before merging. The discussion are not even on
the quality of code which is what modules reviews are supposed to be
for, especially at the module creation.

IMHO, we should just focus on whether it's enabled by default or if
we need to explicitly opt-in in the current state (because of track
selection, etc) and merge it. Then we'll open tickets.

Regards,
--
Alexandre Janniaux
Videolabs