[vlc-devel] [PATCHv3 1/7] input_item: add an owner placeholder

Rémi Denis-Courmont remi at remlab.net
Tue Sep 22 17:10:14 CEST 2020


Le tiistaina 22. syyskuuta 2020, 15.09.52 EEST Thomas Guillem a écrit :
> This will be used by libvlc_media to store the media instance into an
> input_item. This will allow to get the media corresponding to an item
> when propagating media events.

There seems to be an inconsistency here.

We don't have owner data right now, because an input item can be referenced 
and monitored by multiple parties. I don't understand how a single owner 
pointer works with potentially multiple callbacks from different listener.

I'm not saying that the current approach is right and immutable. In fact, most 
other object types with callbacks have a single owner and a single set of 
callbacks, and maybe that's how input item should be.

But at least the current approach is self-consistent.

-- 
レミ・デニ-クールモン
http://www.remlab.net/





More information about the vlc-devel mailing list