[vlc-devel] [PATCH 4/4] ytdl: use redirect for single media

Rémi Denis-Courmont remi at remlab.net
Tue Sep 22 17:25:10 CEST 2020


Le tiistaina 22. syyskuuta 2020, 0.56.42 EEST Pierre Ynard via vlc-devel a 
écrit :
> > Well you can't have it both ways:
> > - Either we redirect, and there is not going to be any metadata.
> > - Or we use a playlist, and we'll have the URL expiry problem (and major
> > 
> >   delay in parsing larger playlists).
> 
> Can we, in an access module, first set metadata on the associated input
> item, then reset the URL, and then fail with a redirect?

You can't do that, and it's very much intended that way.

> I don't see why that fundamentally couldn't work.

That would be a horrible hack. If you redirect, the redirected-to modules is 
expected to provide all controls, including the meta.

And it would indeed fundamentally not work in this particular case, because 
the access has no idea what the meta-data is. The meta-data is extracted by 
the playlist parser, which does not even exist if there a redirection.

> > And playing without metadata is surely no worse than failing to play
> > and also to get any metadata, which is the current situation with VLC
> > for most YoutubeDL-supported sites.
> 
> Let's aim a little higher with this new design than settling for the
> less worse, shall we?

How about no and we limit this patch to its original purpose?

IME, this is already working better than the current system, with URLs not 
expiring, and hundreds more sites working. Titles are available in the 
playlist case as well.

-- 
雷米‧德尼-库尔蒙
http://www.remlab.net/





More information about the vlc-devel mailing list