[vlc-devel] [PATCH 2/4] ytdl: stream filter module for YoutubeDL

[Steve Lhomme]

On 2020-09-24 8:36, Rémi Denis-Courmont wrote:
> Le torstaina 24. syyskuuta 2020, 9.05.34 EEST Steve Lhomme a écrit :
>> On 2020-09-23 17:43, Rémi Denis-Courmont wrote:
>>> +static void Close(vlc_object_t *obj)
>>> +{
>>> +    stream_t *s = (stream_t *)obj;
>>> +    struct ytdl_playlist *sys = s->p_sys;
>>> +
>>> +    msg_Dbg(s, "terminating PID %u", (unsigned)sys->pid);
>>
>> Do we need a debug message everytime a http URL has been opened ? (no)
> 
> Yes. If it gets stuck waiting we know why and on what PID.

But there's a log even if there is no problem.

Also does that mean some http queries may be stuck until explicitly 
closed ? Shouldn't we manage a time-out or something ?

>>> +vlc_module_begin()
>>> +    set_shortname("YT-DL")
>>> +    set_description("YoutubeDL")
>>> +    set_category(CAT_INPUT)
>>> +    set_subcategory(SUBCAT_INPUT_STREAM_FILTER)
>>> +    set_capability("stream_filter", 305)
>>> +    set_callbacks(OpenFilter, Close)
>>> +    add_bool("ytdl", true, N_("Enable YT-DL"), N_("Enable YT-DL"), true)
>>
>> Defines are usually used for such strings.
> 
> And then people forget to delete them, so they stick in the PO files and occupy
> translators needlessly. There are no points in doing that when the string are
> short enough.
> 
>> Also you should probably call it Youtube-DL.
> 
> I have very mixed feelings about that. First I don't want really to show a
> trademark there. And more importantly, I don't want to mislead that it's
> limited to a specific service.

Maybe use a completely different name then.
Also we ship a youtube.lua with plenty of Youtube references.