[vlc-devel] [PATCH 0/5] small mac prefs fixes

[Marvin Scholz]

Hi,

thanks a lot for these patches.
I've reviewed them and tested them and the set LGTM
except for my remarks for the first patch.

On 24 Sep 2020, at 1:04, Lyndon Brown wrote:

> a handful of small fixes for the macosx gui preferences component.
>
>  1. fix for a null deref situation.
>  2. fix for a use-after-free.
>  3. fix relating to ModuleConfigControl stringValue.
>  4. simplification relating to use of module_is_main().
>  5. fix to respect hidden cat/subcat "hack", thus avoiding showing
> options that should be hidden.
>
> a little more to come later. also to follow is a commit to make the
> hidden cat/subcat "hack" standardised.
>
> patches are attached. previews emails (i'm not using git send-mail) for
> review to follow shortly as replies.
>
> please note that although i don't expect any problem, i've not compiled
> these ones. i don't have a mac, don't have any sort of cross compiling
> setup, and don't currently have CI setup on my videolan repo (could use
> help with that).
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel