[vlc-devel] [PATCH 3/8] transcode: simplify test in transcode_video_set_conversions

Steve Lhomme robux4 at ycbcr.xyz
Thu Sep 24 11:50:22 CEST 2020


If b_do_orient true we returned VLC_EGENERIC.
After this, b_do_orient is false, so we will return VLC_SUCCESS no matter what.
---
 modules/stream_out/transcode/video.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/modules/stream_out/transcode/video.c b/modules/stream_out/transcode/video.c
index 16ceb01af93..025a25e44e5 100644
--- a/modules/stream_out/transcode/video.c
+++ b/modules/stream_out/transcode/video.c
@@ -324,7 +324,7 @@ static int transcode_video_set_conversions( sout_stream_t *p_stream,
 
         const es_format_t *p_tmpdst = p_dst;
 
-        if( ! (b_do_scale || b_do_chroma || b_do_orient) )
+        if( !b_do_orient )
             return VLC_SUCCESS;
 
         msg_Dbg( p_stream, "adding (scale %d,chroma %d, orient %d) converters",
-- 
2.26.2



More information about the vlc-devel mailing list