[vlc-devel] [PATCH] contrib: disable rust for the 32bit Intel iOS simulator

[Thomas Guillem]

LGTM indeed.


On Fri, Sep 25, 2020, at 09:57, Rémi Denis-Courmont wrote:
> Le torstaina 24. syyskuuta 2020, 23.06.07 EEST Felix Paul Kühne a écrit :
> > From: Felix Paul Kühne <felix at feepk.net>
> > 
> > ---
> >  contrib/src/main-rust.mak | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/contrib/src/main-rust.mak b/contrib/src/main-rust.mak
> > index edd9c47467..36ca76d8ef 100644
> > --- a/contrib/src/main-rust.mak
> > +++ b/contrib/src/main-rust.mak
> > @@ -15,10 +15,12 @@ else ifdef HAVE_ANDROID
> >  RUST_TARGET = $(HOST)
> >  else ifdef HAVE_IOS
> >  ifneq ($(ARCH),arm) # iOS 32bit is Tier 3
> > +ifneq ($(ARCH),i386) # iOS 32bit is Tier 3
> >  ifndef HAVE_TVOS # tvOS is Tier 3
> >  RUST_TARGET = $(ARCH)-apple-ios
> >  endif
> >  endif
> > +endif
> >  else ifdef HAVE_MACOSX
> >  RUST_TARGET = $(ARCH)-apple-darwin
> >  else ifdef HAVE_SOLARIS
> 
> The patch seems correct to the extent that the existing is correct.
> 
> But I don't think we can have a binary-supported ISA without Rust, unless we 
> don't use Rust.
> 
> -- 
> 雷米‧德尼-库尔蒙
> http://www.remlab.net/
> 
> 
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel