[vlc-devel] [PATCH] video_filter/scale: remove outdated warning

Steve Lhomme robux4 at ycbcr.xyz
Fri Sep 25 14:56:49 CEST 2020


On 2020-09-25 14:41, Rémi Denis-Courmont wrote:
> Le perjantaina 25. syyskuuta 2020, 15.25.33 EEST Steve Lhomme a écrit :
>> Video filters can change the output format including the aspect ratio, as
>> long as b_allow_fmt_out_change is set.
> 
> Well yes but this is a converter, not a filter. This patch seems like it makes
> the module totally unusable, since the flag should always be false for
> converters.

Ah yes, you're right.

I wish this could be enforced by the compiler... As I'm working on push 
filters, there are some classes of filters that will always output a 
single picture (converters), and some that may output more (deinterlacer 
and some video filters). Maybe we could have a particular video filter 
type for converters that would make this easier.


More information about the vlc-devel mailing list