[vlc-devel] [PATCH 1/5] add missing 'since' version tags to obsolete options

Lyndon Brown jnqnfe at gmail.com
Fri Sep 25 18:42:03 CEST 2020


From: Lyndon Brown <jnqnfe at gmail.com>
Date: Fri, 22 Mar 2019 03:16:47 +0000
Subject: add missing 'since' version tags to obsolete options


diff --git a/modules/access/fs.c b/modules/access/fs.c
index dae8c87164..d4330dc1b4 100644
--- a/modules/access/fs.c
+++ b/modules/access/fs.c
@@ -35,7 +35,7 @@ vlc_module_begin ()
     set_shortname( N_("File") )
     set_category( CAT_INPUT )
     set_subcategory( SUBCAT_INPUT_ACCESS )
-    add_obsolete_string( "file-cat" )
+    add_obsolete_string( "file-cat" ) /* since pre-1.0.0 */
     set_capability( "access", 50 )
     add_shortcut( "file", "fd", "stream" )
     set_callbacks( FileOpen, FileClose )
diff --git a/modules/access/v4l2/v4l2.c b/modules/access/v4l2/v4l2.c
index f0b753b5df..04f4979749 100644
--- a/modules/access/v4l2/v4l2.c
+++ b/modules/access/v4l2/v4l2.c
@@ -348,7 +348,7 @@ vlc_module_begin ()
     add_integer( CFG_PREFIX "hue-auto", -1,
                  HUE_AUTO_TEXT, HUE_AUTO_LONGTEXT, true )
         change_integer_list( tristate_vlc, tristate_user )
-    add_obsolete_integer( CFG_PREFIX "black-level" ) /* since Linux 2.6.26 */
+    add_obsolete_integer( CFG_PREFIX "black-level" ) /* since 1.2.0 */
     add_integer( CFG_PREFIX "white-balance-temperature", -1,
                  WHITE_BALANCE_TEMP_TEXT, WHITE_BALANCE_TEMP_LONGTEXT, true )
         /* Ideally, the range should be 2800-6500 */
@@ -385,8 +385,8 @@ vlc_module_begin ()
     add_bool( CFG_PREFIX "vflip", false, VFLIP_TEXT, VFLIP_LONGTEXT, true )
     add_integer( CFG_PREFIX "rotate", -1, ROTATE_TEXT, ROTATE_LONGTEXT, true )
         change_integer_range( -1, 359 )
-    add_obsolete_integer( CFG_PREFIX "hcenter" ) /* since Linux 2.6.26 */
-    add_obsolete_integer( CFG_PREFIX "vcenter" ) /* since Linux 2.6.26 */
+    add_obsolete_integer( CFG_PREFIX "hcenter" ) /* since 1.2.0 */
+    add_obsolete_integer( CFG_PREFIX "vcenter" ) /* since 1.2.0 */
     add_integer( CFG_PREFIX"color-killer", -1,
                  COLOR_KILLER_TEXT, COLOR_KILLER_LONGTEXT, true )
         change_integer_list( tristate_vlc, tristate_user )
@@ -410,6 +410,7 @@ vlc_module_begin ()
               S_CTRLS_LONGTEXT, true )
         change_safe()
 
+    /* since 1.0.0 */
     add_obsolete_string( CFG_PREFIX "adev" )
     add_obsolete_integer( CFG_PREFIX "audio-method" )
     add_obsolete_bool( CFG_PREFIX "stereo" )
diff --git a/modules/audio_filter/audiobargraph_a.c b/modules/audio_filter/audiobargraph_a.c
index e744b52f24..c04d33cf86 100644
--- a/modules/audio_filter/audiobargraph_a.c
+++ b/modules/audio_filter/audiobargraph_a.c
@@ -72,15 +72,15 @@ vlc_module_begin ()
     set_category( CAT_AUDIO )
     set_subcategory( SUBCAT_AUDIO_AFILTER )
 
-    add_obsolete_string( CFG_PREFIX "address" )
-    add_obsolete_integer( CFG_PREFIX "port" )
+    add_obsolete_string( CFG_PREFIX "address" ) /* since 2.2.0 */
+    add_obsolete_integer( CFG_PREFIX "port" ) /* since 2.2.0 */
     add_integer( CFG_PREFIX "bargraph", 1, BARGRAPH_TEXT, BARGRAPH_LONGTEXT, false ) // FIXME: this is a bool
     add_integer( CFG_PREFIX "bargraph_repetition", 4, BARGRAPH_REPETITION_TEXT, BARGRAPH_REPETITION_LONGTEXT, false )
     add_integer( CFG_PREFIX "silence", 1, SILENCE_TEXT, SILENCE_LONGTEXT, false ) // FIXME: this is a bool
     add_integer( CFG_PREFIX "time_window", 5000, TIME_WINDOW_TEXT, TIME_WINDOW_LONGTEXT, false )
     add_float( CFG_PREFIX "alarm_threshold", 0.02, ALARM_THRESHOLD_TEXT, ALARM_THRESHOLD_LONGTEXT, false )
     add_integer( CFG_PREFIX "repetition_time", 2000, REPETITION_TIME_TEXT, REPETITION_TIME_LONGTEXT, false )
-    add_obsolete_integer( CFG_PREFIX "connection_reset" )
+    add_obsolete_integer( CFG_PREFIX "connection_reset" ) /* since 2.2.0 */
 
     set_callbacks( Open, Close )
 vlc_module_end ()
diff --git a/modules/audio_output/directsound.c b/modules/audio_output/directsound.c
index 582771d178..2bb54c1d28 100644
--- a/modules/audio_output/directsound.c
+++ b/modules/audio_output/directsound.c
@@ -74,7 +74,7 @@ vlc_module_begin ()
 
     add_string( "directx-audio-device", NULL,
              DEVICE_TEXT, DEVICE_LONGTEXT, false )
-    add_obsolete_string( "directx-audio-device-name")
+    add_obsolete_string( "directx-audio-device-name") /* since 2.1.0 */
     add_bool( "directx-audio-float32", true, FLOAT_TEXT,
               FLOAT_LONGTEXT, true )
     add_string( "directx-audio-speaker", "Windows default",
diff --git a/modules/codec/svcdsub.c b/modules/codec/svcdsub.c
index d742692d64..04d392caba 100644
--- a/modules/codec/svcdsub.c
+++ b/modules/codec/svcdsub.c
@@ -52,7 +52,7 @@ vlc_module_begin ()
     set_capability( "spu decoder", 50 )
     set_callbacks( DecoderOpen, DecoderClose )
 
-    add_obsolete_integer ( "svcdsub-debug" )
+    add_obsolete_integer ( "svcdsub-debug" ) /* since 1.2.0 */
 
     add_submodule ()
     set_description( N_("Philips OGT (SVCD subtitle) packetizer") )
diff --git a/modules/codec/x264.c b/modules/codec/x264.c
index 1e04a9ca01..a84d2c22a3 100644
--- a/modules/codec/x264.c
+++ b/modules/codec/x264.c
@@ -471,7 +471,7 @@ vlc_module_begin ()
                  SCENE_LONGTEXT, true )
         change_integer_range( -1, 100 )
 
-    add_obsolete_bool( SOUT_CFG_PREFIX "pre-scenecut" )
+    add_obsolete_bool( SOUT_CFG_PREFIX "pre-scenecut" ) /* since 1.0.0 */
 
     add_integer( SOUT_CFG_PREFIX "bframes", 3, BFRAMES_TEXT,
                  BFRAMES_LONGTEXT, true )
@@ -643,7 +643,7 @@ vlc_module_begin ()
     add_integer( SOUT_CFG_PREFIX "subme", 7, SUBME_TEXT,
                  SUBME_LONGTEXT, true )
 
-    add_obsolete_bool( SOUT_CFG_PREFIX "b-rdo" )
+    add_obsolete_bool( SOUT_CFG_PREFIX "b-rdo" ) /* since 1.0.0 */
 
     add_bool( SOUT_CFG_PREFIX "mixed-refs", true, MIXED_REFS_TEXT,
               MIXED_REFS_LONGTEXT, true )
@@ -651,7 +651,7 @@ vlc_module_begin ()
     add_bool( SOUT_CFG_PREFIX "chroma-me", true, CHROMA_ME_TEXT,
               CHROMA_ME_LONGTEXT, true )
 
-    add_obsolete_bool( SOUT_CFG_PREFIX "bime" )
+    add_obsolete_bool( SOUT_CFG_PREFIX "bime" ) /* since 1.0.0 */
 
     add_bool( SOUT_CFG_PREFIX "8x8dct", true, TRANSFORM_8X8DCT_TEXT,
               TRANSFORM_8X8DCT_LONGTEXT, true )
diff --git a/modules/control/dummy.c b/modules/control/dummy.c
index 4e95c49fe0..1ed3fc92e8 100644
--- a/modules/control/dummy.c
+++ b/modules/control/dummy.c
@@ -41,7 +41,7 @@ vlc_module_begin ()
     set_capability( "interface", 0 )
     set_callback( Open )
 #if defined(_WIN32) && !VLC_WINSTORE_APP
-    add_obsolete_bool( "dummy-quiet" )
+    add_obsolete_bool( "dummy-quiet" ) /* since 4.0.0 */
 #endif
 vlc_module_end ()
 
diff --git a/modules/demux/mpeg/ts.c b/modules/demux/mpeg/ts.c
index 8a98e3c6a3..9ada5c8f17 100644
--- a/modules/demux/mpeg/ts.c
+++ b/modules/demux/mpeg/ts.c
@@ -164,7 +164,7 @@ vlc_module_begin ()
     add_integer_with_range( "ts-generated-pcr-offset", 120, 0, 500,
                             TS_GENERATED_PCR_OFFSET_TEXT, NULL, true )
 
-    add_obsolete_bool( "ts-silent" );
+    add_obsolete_bool( "ts-silent" ) /* since 2.1.0 */
 
     set_capability( "demux", 10 )
     set_callbacks( Open, Close )
diff --git a/modules/hw/mmal/codec.c b/modules/hw/mmal/codec.c
index a10ac5637a..af5742dbac 100644
--- a/modules/hw/mmal/codec.c
+++ b/modules/hw/mmal/codec.c
@@ -54,7 +54,7 @@ vlc_module_begin()
     set_description(N_("MMAL-based decoder plugin for Raspberry Pi"))
     set_capability("video decoder", 90)
     add_shortcut("mmal_decoder")
-    add_obsolete_bool("mmal-opaque")
+    add_obsolete_bool("mmal-opaque") /* since 4.0.0 */
     set_callbacks(OpenDecoder, CloseDecoder)
 vlc_module_end()
 
diff --git a/modules/spu/audiobargraph_v.c b/modules/spu/audiobargraph_v.c
index de3f9627a6..858fcf5e45 100644
--- a/modules/spu/audiobargraph_v.c
+++ b/modules/spu/audiobargraph_v.c
@@ -80,14 +80,14 @@ vlc_module_begin ()
     set_shortname(N_("Audio Bar Graph Video"))
     add_shortcut("audiobargraph_v")
 
-    add_obsolete_string(CFG_PREFIX "i_values")
+    add_obsolete_string(CFG_PREFIX "i_values") /* since 2.2.0 */
     add_integer(CFG_PREFIX "x", 0, POSX_TEXT, POSX_LONGTEXT, true)
     add_integer(CFG_PREFIX "y", 0, POSY_TEXT, POSY_LONGTEXT, true)
     add_integer_with_range(CFG_PREFIX "transparency", 255, 0, 255,
         TRANS_TEXT, TRANS_LONGTEXT, false)
     add_integer(CFG_PREFIX "position", -1, POS_TEXT, POS_LONGTEXT, false)
         change_integer_list(pi_pos_values, ppsz_pos_descriptions)
-    add_obsolete_integer(CFG_PREFIX "alarm")
+    add_obsolete_integer(CFG_PREFIX "alarm") /* since 2.2.0 */
     add_integer(CFG_PREFIX "barWidth", 10, BARWIDTH_TEXT, BARWIDTH_LONGTEXT, true)
     add_integer(CFG_PREFIX "barHeight", 400, BARHEIGHT_TEXT, BARHEIGHT_LONGTEXT, true)
 
diff --git a/modules/stream_out/chromecast/cast.cpp b/modules/stream_out/chromecast/cast.cpp
index 944bde923f..35f3f3889b 100644
--- a/modules/stream_out/chromecast/cast.cpp
+++ b/modules/stream_out/chromecast/cast.cpp
@@ -225,8 +225,8 @@ vlc_module_begin ()
     add_bool(SOUT_CFG_PREFIX "video", true, NULL, NULL, false)
         change_private()
     add_integer(SOUT_CFG_PREFIX "http-port", HTTP_PORT, HTTP_PORT_TEXT, HTTP_PORT_LONGTEXT, false)
-    add_obsolete_string(SOUT_CFG_PREFIX "mux")
-    add_obsolete_string(SOUT_CFG_PREFIX "mime")
+    add_obsolete_string(SOUT_CFG_PREFIX "mux") /* since 4.0.0 */
+    add_obsolete_string(SOUT_CFG_PREFIX "mime") /* since 4.0.0 */
     add_renderer_opts(SOUT_CFG_PREFIX)
 
     add_submodule()
diff --git a/modules/text_renderer/freetype/freetype.c b/modules/text_renderer/freetype/freetype.c
index 5b5fc2d08f..c9322968a9 100644
--- a/modules/text_renderer/freetype/freetype.c
+++ b/modules/text_renderer/freetype/freetype.c
@@ -190,9 +190,9 @@ vlc_module_begin ()
                             CACHE_SIZE_TEXT, CACHE_SIZE_LONGTEXT, true )
         change_safe()
 
-    add_obsolete_integer( "freetype-fontsize" );
-    add_obsolete_integer( "freetype-rel-fontsize" );
-    add_obsolete_integer( "freetype-effect" );
+    add_obsolete_integer( "freetype-fontsize" ); /* since 4.0.0 */
+    add_obsolete_integer( "freetype-rel-fontsize" ); /* since 4.0.0 */
+    add_obsolete_integer( "freetype-effect" ); /* since 1.2.0 */
 
     add_bool( "freetype-yuvp", false, YUVP_TEXT,
               YUVP_LONGTEXT, true )
diff --git a/modules/video_output/decklink.cpp b/modules/video_output/decklink.cpp
index 4f25dc6d01..8fd60f8b47 100644
--- a/modules/video_output/decklink.cpp
+++ b/modules/video_output/decklink.cpp
@@ -285,7 +285,7 @@ vlc_module_begin()
     set_capability("audio output", 0)
     set_callbacks (OpenAudio, CloseAudio)
     set_section(N_("DeckLink Audio Options"), NULL)
-    add_obsolete_string("audio-connection")
+    add_obsolete_string("audio-connection") /* since 2.2.0 */
     add_integer(AUDIO_CFG_PREFIX "audio-rate", 48000,
                 RATE_TEXT, RATE_LONGTEXT, true)
     add_integer(AUDIO_CFG_PREFIX "audio-channels", 2,
diff --git a/modules/video_output/fb.c b/modules/video_output/fb.c
index 4ea44c154c..12b68a1d3f 100644
--- a/modules/video_output/fb.c
+++ b/modules/video_output/fb.c
@@ -82,7 +82,7 @@ vlc_module_begin ()
     add_loadfile(FB_DEV_VAR, "/dev/fb0", DEVICE_TEXT, DEVICE_LONGTEXT)
     add_bool("fb-tty", true, TTY_TEXT, TTY_LONGTEXT, true)
     add_string( "fb-chroma", NULL, CHROMA_TEXT, CHROMA_LONGTEXT, true )
-    add_obsolete_string("fb-aspect-ratio")
+    add_obsolete_string("fb-aspect-ratio") /* since 1.1.0 */
     add_integer("fb-mode", 4, FB_MODE_TEXT, FB_MODE_LONGTEXT,
                  true)
     add_obsolete_bool("fb-hw-accel") /* since 4.0.0 */
diff --git a/modules/video_splitter/panoramix.c b/modules/video_splitter/panoramix.c
index 9790bb2c4a..0af4abe549 100644
--- a/modules/video_splitter/panoramix.c
+++ b/modules/video_splitter/panoramix.c
@@ -167,9 +167,9 @@ vlc_module_begin()
     add_integer_with_range( CFG_PREFIX "bz-whitelevel-green", 0, 0, 255, GGAMMA_WL_TEXT, GGAMMA_WL_LONGTEXT, true )
     add_integer_with_range( CFG_PREFIX "bz-whitelevel-blue", 0, 0, 255, BGAMMA_WL_TEXT, BGAMMA_WL_LONGTEXT, true )
 #ifndef _WIN32
-    add_obsolete_bool( CFG_PREFIX "xinerama" );
+    add_obsolete_bool( CFG_PREFIX "xinerama" ) /* since 1.1.0 */
 #endif
-    add_obsolete_bool( CFG_PREFIX "offset-x" )
+    add_obsolete_bool( CFG_PREFIX "offset-x" ) /* since 1.1.0 */
 #endif
 
     add_string( CFG_PREFIX "active", NULL, ACTIVE_TEXT, ACTIVE_LONGTEXT, true )
diff --git a/src/libvlc-module.c b/src/libvlc-module.c
index 681f753f70..43a38de1bc 100644
--- a/src/libvlc-module.c
+++ b/src/libvlc-module.c
@@ -1890,11 +1890,11 @@ vlc_module_begin ()
                 false )
     add_password("http-proxy-pwd", NULL, PROXY_PASS_TEXT, PROXY_PASS_LONGTEXT)
 #else
-    add_obsolete_string( "http-proxy" )
-    add_obsolete_string( "http-proxy-pwd" )
+    add_obsolete_string( "http-proxy" ) /* since 4.0.0 */
+    add_obsolete_string( "http-proxy-pwd" ) /* since 4.0.0 */
 
 #endif
-    add_obsolete_bool( "http-use-IE-proxy" )
+    add_obsolete_bool( "http-use-IE-proxy" ) /* since 4.0.0 */
 
     set_section( N_( "Socks proxy") , NULL )
     add_string( "socks", NULL,
@@ -2028,7 +2028,7 @@ vlc_module_begin ()
 
     set_subcategory( SUBCAT_INPUT_SCODEC )
 
-    add_obsolete_bool( "prefer-system-codecs" )
+    add_obsolete_bool( "prefer-system-codecs" ) /* since 1.2.0 */
 
     set_subcategory( SUBCAT_INPUT_STREAM_FILTER )
 
@@ -2082,7 +2082,7 @@ vlc_module_begin ()
 
 /* CPU options */
     set_category( CAT_ADVANCED )
-    add_obsolete_bool( "fpu" )
+    add_obsolete_bool( "fpu" ) /* since 1.1.0 */
 #if defined( __i386__ ) || defined( __x86_64__ )
     add_obsolete_bool( "mmx" ) /* since 2.0.0 */
     add_obsolete_bool( "3dn" ) /* since 2.0.0 */
@@ -2194,7 +2194,7 @@ vlc_module_begin ()
     add_integer( "fetch-art-threads", 1, FETCH_ART_THREADS_TEXT,
                  FETCH_ART_THREADS_LONGTEXT, false )
 
-    add_obsolete_integer( "album-art" )
+    add_obsolete_integer( "album-art" ) /* since 2.2.0 */
     add_bool( "metadata-network-access", false, METADATA_NETWORK_TEXT,
                  METADATA_NETWORK_TEXT, false )
 
@@ -2707,7 +2707,7 @@ vlc_module_begin ()
             DEINTERLACE_MODE_KEY_TEXT, DEINTERLACE_MODE_KEY_LONGTEXT)
     add_key("key-intf-show", KEY_INTF_TOGGLE_FSC,
             INTF_TOGGLE_FSC_KEY_TEXT, INTF_TOGGLE_FSC_KEY_TEXT)
-    add_obsolete_inner( "key-intf-hide", CONFIG_ITEM_KEY )
+    add_obsolete_inner( "key-intf-hide", CONFIG_ITEM_KEY ) /* since 1.2.0 */
 
     add_key("key-intf-boss", KEY_INTF_BOSS,
             INTF_BOSS_KEY_TEXT, INTF_BOSS_KEY_LONGTEXT)
@@ -2872,7 +2872,7 @@ vlc_module_begin ()
         change_volatile ()
     add_bool( "ignore-config", true, IGNORE_CONFIG_TEXT, "", false )
         change_volatile ()
-    add_obsolete_bool( "save-config" )
+    add_obsolete_bool( "save-config" ) /* since 1.1.0 */
     add_bool( "reset-config", false, RESET_CONFIG_TEXT, "", false )
         change_volatile ()
 #ifdef HAVE_DYNAMIC_PLUGINS



More information about the vlc-devel mailing list