[vlc-devel] [PATCH 7/8] decklink: add missing option category before options

Lyndon Brown jnqnfe at gmail.com
Sat Sep 26 00:33:09 CEST 2020


From: Lyndon Brown <jnqnfe at gmail.com>
Date: Sat, 23 Mar 2019 05:06:47 +0000
Subject: decklink: add missing option category before options

the `decklink-output-card-index` option had been specified with no
prior specification of cat+subcat. not having a cat+subcat prior to an
option means that the option is not shown in the Qt preferences
interface (and maybe others).

note that I have left it disabled due to the way the Qt GUI currently
deals with plugin options - making all options from a plugin available
from a single entry located under the first cat/subcat specified - and I
don't want to affect the location currently selected with this. it
should only be enabled either if it is considered okay for the entire
set of options from this plugin to move to a different location in the
preferences interface, or until things are revised to allow plugin
options to be spread out across multiple locations in the preferences
tree where multiple different cat+subcats are specified.

thus for the time being, the option in question here continues to
not be shown in the preferences GUI.

diff --git a/modules/video_output/decklink.cpp b/modules/video_output/decklink.cpp
index 4f25dc6d01..d5f6d0c1d0 100644
--- a/modules/video_output/decklink.cpp
+++ b/modules/video_output/decklink.cpp
@@ -247,6 +247,8 @@ static void CloseAudio          (vlc_object_t *);
 vlc_module_begin()
     set_shortname(N_("DecklinkOutput"))
     set_description(N_("Output module to write to Blackmagic SDI card"))
+    //set_category( CAT_INPUT )
+    //set_subcategory( SUBCAT_INPUT_GENERAL )
     set_section(N_("DeckLink General Options"), NULL)
     add_integer(CFG_PREFIX "card-index", 0,
                 CARD_INDEX_TEXT, CARD_INDEX_LONGTEXT, true)



More information about the vlc-devel mailing list