[vlc-devel] [PATCH 3/12] esformat: fix ORIENT_LEFT_BOTTOM and ORIENT_RIGHT_TOP descriptions

[Romain Vimont]

On Thu, Sep 24, 2020 at 11:29:58PM +0100, Lyndon Brown wrote:
> From: Lyndon Brown <jnqnfe at gmail.com>
> Date: Sun, 7 Jan 2018 19:22:38 +0000
> Subject: esformat: fix ORIENT_LEFT_BOTTOM and ORIENT_RIGHT_TOP descriptions
> 
> They had 90 degree clockwise / anti-clockwise rotation the wrong way
> around.
> 
> diff --git a/include/vlc_es.h b/include/vlc_es.h
> index a7af6c118c..841fa05bf6 100644
> --- a/include/vlc_es.h
> +++ b/include/vlc_es.h
> @@ -181,8 +181,8 @@ typedef enum video_orientation_t
>      ORIENT_BOTTOM_LEFT, /**< Flipped vertically */
>      ORIENT_BOTTOM_RIGHT, /**< Rotated 180 degrees */
>      ORIENT_LEFT_TOP, /**< Transposed */
> -    ORIENT_LEFT_BOTTOM, /**< Rotated 90 degrees clockwise */
> -    ORIENT_RIGHT_TOP, /**< Rotated 90 degrees anti-clockwise */
> +    ORIENT_LEFT_BOTTOM, /**< Rotated 90 degrees anti-clockwise */
> +    ORIENT_RIGHT_TOP, /**< Rotated 90 degrees clockwise */

I think is was correct before the patch:

ORIENT_LEFT_BOTTOM: top line represents LEFT, left column BOTTOM.

 original          rotated
  +-T-+             +-L-+
  L   R    ---->    B   T    : it's rotated 90 degrees clockwise
  +-B-+             +-R-+

Similarly ORIENT_RIGHT_TOP was correct.

Regards

>      ORIENT_RIGHT_BOTTOM, /**< Anti-transposed */
>  
>      ORIENT_NORMAL      = ORIENT_TOP_LEFT,
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel