[vlc-devel] [PATCH 3/12] esformat: fix ORIENT_LEFT_BOTTOM and ORIENT_RIGHT_TOP descriptions

Rémi Denis-Courmont remi at remlab.net
Sat Sep 26 17:04:03 CEST 2020


Le lauantaina 26. syyskuuta 2020, 13.48.59 EEST Romain Vimont a écrit :
> On Thu, Sep 24, 2020 at 11:29:58PM +0100, Lyndon Brown wrote:
> > From: Lyndon Brown <jnqnfe at gmail.com>
> > Date: Sun, 7 Jan 2018 19:22:38 +0000
> > Subject: esformat: fix ORIENT_LEFT_BOTTOM and ORIENT_RIGHT_TOP
> > descriptions
> > 
> > They had 90 degree clockwise / anti-clockwise rotation the wrong way
> > around.
> > 
> > diff --git a/include/vlc_es.h b/include/vlc_es.h
> > index a7af6c118c..841fa05bf6 100644
> > --- a/include/vlc_es.h
> > +++ b/include/vlc_es.h
> > @@ -181,8 +181,8 @@ typedef enum video_orientation_t
> > 
> >      ORIENT_BOTTOM_LEFT, /**< Flipped vertically */
> >      ORIENT_BOTTOM_RIGHT, /**< Rotated 180 degrees */
> >      ORIENT_LEFT_TOP, /**< Transposed */
> > 
> > -    ORIENT_LEFT_BOTTOM, /**< Rotated 90 degrees clockwise */
> > -    ORIENT_RIGHT_TOP, /**< Rotated 90 degrees anti-clockwise */
> > +    ORIENT_LEFT_BOTTOM, /**< Rotated 90 degrees anti-clockwise */
> > +    ORIENT_RIGHT_TOP, /**< Rotated 90 degrees clockwise */
> 
> I think is was correct before the patch:
> 
> ORIENT_LEFT_BOTTOM: top line represents LEFT, left column BOTTOM.

Left-bottom means the top row is stored in the left column and the left column 
is stored in the bottom row. In my book, that means the picture has been 
"rotated 90 degrees anti-clockwise", and a rotation of 90 degrees clockwise is 
necessary to show it correctly.

I think the patch was correct.

-- 
雷米‧德尼-库尔蒙
http://www.remlab.net/





More information about the vlc-devel mailing list