[vlc-devel] [PATCH] plugins: do not capture set of null-capability modules

[Rémi Denis-Courmont]

Le lauantaina 26. syyskuuta 2020, 23.28.03 EEST Lyndon Brown a écrit :
> On Sat, 2020-09-26 at 22:10 +0300, Rémi Denis-Courmont wrote:
> > Le lauantaina 26. syyskuuta 2020, 21.58.29 EEST Lyndon Brown a écrit
> > 
> > > attached. preview below.
> > > 
> > > i can move the discussion of the reasoning for skipping null-cap
> > > modules from the comment block to the commit log if preferred.
> > > similarly i'll move the minor documentation enhancements i slipped
> > > in
> > > here to a separate commit if preferred.
> > 
> > This is semantically wrong. Notionally we want to store all modules.
> > It's just
> > so that currently the store operation only manages capabilities.
> > 
> > And even then, there are no particular reasons not to keep track of
> > modules
> > with "none" capabilities. For all I know, some GUI could want to list
> > modules
> > sorted by caps.
> 
> The "store" function indeed only registers a module into a capability
> list. I see absolutely no useful purpose to capturing null/none/no
> capability modules in doing this.

Not having to add a gratuitious special case that makes the code needlessly 
complex is one. Listing by capabilities is another.

And the real problem is that we should not force plugins to create a module if 
they don't need one.

-1

-- 
Rémi Denis-Courmont
http://www.remlab.net/