[vlc-devel] [PATCH] modules: use 16-bit ints for option counts

Rémi Denis-Courmont remi at remlab.net
Sun Sep 27 22:38:55 CEST 2020


Le sunnuntaina 27. syyskuuta 2020, 23.03.24 EEST Lyndon Brown a écrit :
> I don't think it's very fair to call the patch broken, an assert is
> added to the function where options are added into the system as a
> precaution to catching the unlikely scenario of there ever being such a
> bug causing a huge volume of creation requests.

It is broken. It's trivial to construct a scenario where the option list will 
overflow. And as a general rule, we do not use assertions to handle errors.

-- 
レミ・デニ-クールモン
http://www.remlab.net/





More information about the vlc-devel mailing list