[vlc-devel] [vlc-commits] ytdl: stream filter module for YoutubeDL

[Steve Lhomme]

On 2020-09-27 15:16, Rémi Denis-Courmont wrote:
> vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Sun Sep 20 21:46:41 2020 +0300| [4fa60bf98d9697c09a412c35a38a4a460044fa2a] | committer: Rémi Denis-Courmont
> 
> ytdl: stream filter module for YoutubeDL
> 
> This passes every HTTP(S) URL through YoutubeDL to extract playlists
> or media.
> 
>> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=4fa60bf98d9697c09a412c35a38a4a460044fa2a
> ---
> 
>   NEWS                      |   1 +
>   modules/demux/Makefile.am |  10 +-
>   modules/demux/ytdl.c      | 270 ++++++++++++++++++++++++++++++++++++++++++++++

Why is this in demux/ and not stream_filter/ ?

>   po/POTFILES.in            |   1 +
>   4 files changed, 281 insertions(+), 1 deletion(-)
> 
> diff --git a/NEWS b/NEWS
> index 9af6a77b8f..7eb1a72567 100644
> --- a/NEWS
> +++ b/NEWS
> @@ -65,6 +65,7 @@ Access:
>    * Audio CD data tracks are now correctly detected and skipped
>    * Deprecates Audio CD CDDB lookups in favor of more accurate Musicbrainz
>    * Improved CD-TEXT and added Shift-JIS encoding support
> + * Support for YoutubeDL (where available).
>   
>   Access output:
>    * Added support for the RIST (Reliable Internet Stream Transport) Protocol
> diff --git a/modules/demux/Makefile.am b/modules/demux/Makefile.am
> index d7b8df6ece..88075b06a0 100644
> --- a/modules/demux/Makefile.am
> +++ b/modules/demux/Makefile.am
> @@ -505,6 +505,14 @@ libadaptive_plugin_la_LIBADD += $(GCRYPT_LIBS)
>   endif
>   demux_LTLIBRARIES += libadaptive_plugin.la
>   
> +libytdl_plugin_la_SOURCES = demux/ytdl.c
> +libytdl_plugin_la_LIBADD = libvlc_json.la
> +if !HAVE_WIN32
> +if !HAVE_ANDROID
> +demux_LTLIBRARIES += libytdl_plugin.la
> +endif
> +endif
> +
>   libnoseek_plugin_la_SOURCES = demux/filter/noseek.c
>   demux_LTLIBRARIES += libnoseek_plugin.la
>   
> @@ -519,6 +527,6 @@ libvlc_json_la_SOURCES = \
>   	demux/json/grammar.y \
>   	demux/json/json.c demux/json/json.h
>   libvlc_json_la_CPPFLAGS = $(AM_CPPFLAGS) -I$(srcdir)/demux/json
> -libvlc_json_la_LIBADD = $(LTLIBVLCCORE) ../compat/libcompat.la
> +libvlc_json_la_LIBADD = $(LTLIBVLCCORE) ../compat/libcompat.la $(LIBM)

Does reverting this patch make the new json parser not build properly ?

>   libvlc_json_la_LDFLAGS = -static
>   noinst_LTLIBRARIES += libvlc_json.la