[vlc-devel] [PATCH] rootwrap: fix warning

Rémi Denis-Courmont remi at remlab.net
Mon Sep 28 09:06:42 CEST 2020


Hi,

This patch is just plain wrong. RTFM.

Le 28 septembre 2020 02:36:27 GMT+03:00, Lyndon Brown <jnqnfe at gmail.com> a écrit :
>attached. preview:
>
>From: Lyndon Brown <jnqnfe at gmail.com>
>Date: Sat, 30 Mar 2019 02:43:45 +0000
>Subject: rootwrap: fix warning
>
>
>diff --git a/bin/rootwrap.c b/bin/rootwrap.c
>index 0258773b90..3de054e73a 100644
>--- a/bin/rootwrap.c
>+++ b/bin/rootwrap.c
>@@ -248,7 +248,8 @@ int main (int argc, char *argv[])
>        fputs("Cannot determine unprivileged user for VLC!\n", stderr);
>         exit (1);
>     }
>-    setuid (uid);
>+    if (!setuid (uid))
>+        exit (1);
> 
>     if (!setuid (0)) /* sanity check: we cannot get root back */
>         exit (1);

-- 
Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20200928/0486e033/attachment.html>


More information about the vlc-devel mailing list