[vlc-devel] [vlc-commits] JSON representation and Javascript unescaping

[Thomas Guillem]

Is it possible to get rid of one implementation?

On Mon, Sep 28, 2020, at 13:28, Rémi Denis-Courmont wrote:
> Hi,
> 
> That was already mentioned in one of the review thread. Also that that code is horrible, with its at best dubious pointer casts, most likely aliasing bugs.
> 
> And looking at it again, it seems to decode strings incorrectly to CESU-8 instead of UTF-8.
> 
> Le 28 septembre 2020 14:02:37 GMT+03:00, Francois Cartegnie <fcvlcdev at free.fr> a écrit :
>> Le 28/09/2020 à 10:20, Thomas Guillem a écrit :
>> > 
>>> 
>>> On Sun, Sep 27, 2020, at 15:16, Rémi Denis-Courmont wrote:
>>>>  vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Sun Sep 
>>>>  27 15:19:42 2020 +0300| [c4c1bc81e819cee65f673a10f58e40f56eab9704] | 
>>>>  committer: Rémi Denis-Courmont
>>>> 
>>>>  JSON representation and Javascript unescaping
>>>> 
>>>>> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=c4c1bc81e819cee65f673a10f58e40f56eab9704
>>>>   modules/demux/Makefile.am |   7 +++
>>>>   modules/demux/json/json.c | 145 ++++++++++++++++++++++++++++++++++++++++++++++
>>>>   modules/demux/json/json.h |  73 +++++++++++++++++++++++
>>>>   3 files changed, 225 insertions(+)
>> 
>> Speaking of NIH symdrom we already had a proven helper for years:
>> webservices/json.*
> 
> -- 
> Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté. 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20200928/d0fa4809/attachment.html>