[vlc-devel] [vlc-commits] JSON representation and Javascript unescaping

[Thomas Guillem]

That is why code review is important.

We would have said to either fix the "dubious" JSON parser, or remove it (and fix the old JSON parser user to use the new one). We should avoid code duplication at maximum, remember the adaptive HTTP discussions...

And indeed, getting code merged can be a very long and fastidious process. For small patch set, it can take 1 week, sometimes it takes months on bigger ones.

On Mon, Sep 28, 2020, at 14:26, Rémi Denis-Courmont wrote:
> https://mailman.videolan.org/pipermail/vlc-devel/2020-September/137937.html
> 
> Le 28 septembre 2020 15:17:49 GMT+03:00, Francois Cartegnie <fcvlcdev at free.fr> a écrit :
>> Le 28/09/2020 à 13:28, Rémi Denis-Courmont a écrit :
>>> Hi,
>>> 
>>> That was already mentioned in one of the review thread. Also that that code is horrible, with its at best dubious pointer casts, most likely aliasing bugs.
>> 
>> ????
>> I see no thread about json except the one from today about the commits.
>> 
>> The last subject mentioning json was on 27/08 about lua/http.
>> 
>>> And looking at it again, it seems to decode strings incorrectly to CESU-8 instead of UTF-8.
>> 
> 
> -- 
> Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté. 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20200928/40199466/attachment.html>