[vlc-devel] [vlc-commits] JSON representation and Javascript unescaping
Steve Lhomme
robux4 at ycbcr.xyz
Mon Sep 28 16:54:31 CEST 2020
On 2020-09-28 16:31, Rémi Denis-Courmont wrote:
> Le maanantaina 28. syyskuuta 2020, 16.52.17 EEST Thomas Guillem a écrit :
>>> Congratulations because I'm even more disgusted and even less likely to go
>>> through code review onward, than I already was from other people's last
>>> week's obstructionism.
>
>> I don't see obstructionism, lot of people were interested, some of us didn't
>> fully understand the implication of such patch (some us didn't even know
>> that ytdl handled more than 100 sites and not only one).
>
> Rejecting one log message per input is not misunderstanding, it's obstruction.
> And that's just the last example.
>
>> I was personally afraid of the performance consequence (but I was still very
>> enthusiastic by your patch set).
>
> I never said that *you* did obstructionism.
Since I'm the one attacked here, I will reply.
I still think it's wrong. I'm allowed to say so. That's not a blocker
for merging the code. It's just ugly and unnecessary. But as long as it
never lands on Windows I don't really care.
More information about the vlc-devel
mailing list