[vlc-devel] [PATCHv3 0/7] lib: fix libvlc_MediaPlayerMediaChanged event

[Thomas Guillem]

OK, with this patch set ? Here is the last branch addressing Rémi's review about input_item ref counting when holding it for comparison:
https://code.videolan.org/tguillem/vlc/commits/lib3

On Tue, Sep 22, 2020, at 14:09, Thomas Guillem wrote:
> Changes since the V2 
> https://mailman.videolan.org/pipermail/vlc-devel/2020-September/138006.html
> 
>  - Update services_discovery documentation
>  - Store the original item pointer in order to fix media_discoverer item
>    comparisons
> 
> Thomas Guillem (7):
>   input_item: add an owner placeholder
>   input_item: add owner_data to Copy()
>   sd: update services_discovery_AddSubItem documentation
>   lib: media_discoverer: compare with the original item
>   lib: media: refactor input_item creation
>   lib: media: copy the input item
>   lib: media_player: fix libvlc_MediaPlayerMediaChanged event
> 
>  include/vlc/libvlc_media_player.h      | 11 ++-
>  include/vlc_input_item.h               | 21 +++---
>  include/vlc_services_discovery.h       |  5 ++
>  lib/media.c                            | 95 ++++++++++++++------------
>  lib/media_discoverer.c                 |  4 +-
>  lib/media_internal.h                   |  3 +
>  lib/media_player.c                     | 28 ++------
>  modules/demux/playlist/asx.c           |  3 +-
>  modules/demux/playlist/m3u.c           |  2 +-
>  modules/gui/qt/playlist/media.hpp      |  2 +-
>  modules/lua/libs/sd.c                  |  2 +-
>  modules/lua/vlc.c                      |  2 +-
>  modules/misc/medialibrary/entities.cpp |  2 +-
>  modules/services_discovery/udev.c      |  3 +-
>  modules/services_discovery/upnp.cpp    |  2 +-
>  modules/services_discovery/xcb_apps.c  |  2 +-
>  src/input/item.c                       | 13 ++--
>  17 files changed, 112 insertions(+), 88 deletions(-)
> 
> -- 
> 2.28.0
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel