[vlc-devel] [PATCH] fps: hold the extra pictures we send

[Steve Lhomme]

The same picture is supposed to be filtered or rendered at a different date,
but the pixels should be the same. The content is not going to be changed in
the pictures we output from this filter.
---
 modules/video_filter/fps.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/modules/video_filter/fps.c b/modules/video_filter/fps.c
index 4e6a59dfd66..5dffffe4d35 100644
--- a/modules/video_filter/fps.c
+++ b/modules/video_filter/fps.c
@@ -116,10 +116,7 @@ static picture_t *Filter( filter_t *p_filter, picture_t *p_picture)
         should be avoided, it's only here as filter should work in that direction too*/
     while( unlikely( (date_Get( &p_sys->next_output_pts ) + p_sys->i_output_frame_interval ) < p_picture->date ) )
     {
-        picture_t *p_tmp = NULL;
-        p_tmp = picture_NewFromFormat( &p_filter->fmt_out.video );
-
-        picture_Copy( p_tmp, p_sys->p_previous_pic);
+        picture_t *p_tmp = picture_Hold( p_sys->p_previous_pic );
         p_tmp->date = date_Get( &p_sys->next_output_pts );
 
         last_pic = vlc_picture_chain_Append( &p_sys->p_previous_pic, last_pic, p_tmp );
-- 
2.26.2