[vlc-devel] [PATCH 5/5] purge obsolete options removed in v2.2
Alexandre Janniaux
ajanni at videolabs.io
Tue Sep 29 09:36:45 CEST 2020
Hi,
On Mon, Sep 28, 2020 at 11:04:21AM +0300, Rémi Denis-Courmont wrote:
> Hi,
>
> The whole point of putting the version in comments is to have more than one major version or history. Otherwise we could just as well remove all old options when forking a stable.
>
> I think it's too early to remove 2.x stuff, especially 2.2.
I agree with Rémi, especially given the only available documentation
probably references them currently. Better wait for the new user
documentation to be complete before removing the deprecated features
before 3.x.
Regards,
--
Alexandre Janniaux
Videolabs
>
> Le 25 septembre 2020 19:43:50 GMT+03:00, Lyndon Brown <jnqnfe at gmail.com> a écrit :
> >From: Lyndon Brown <jnqnfe at gmail.com>
> >Date: Fri, 22 Mar 2019 04:25:01 +0000
> >Subject: purge obsolete options removed in v2.2
> >
> >
> >diff --git a/modules/audio_filter/audiobargraph_a.c
> >b/modules/audio_filter/audiobargraph_a.c
> >index c04d33cf86..5213a4a792 100644
> >--- a/modules/audio_filter/audiobargraph_a.c
> >+++ b/modules/audio_filter/audiobargraph_a.c
> >@@ -72,15 +72,12 @@ vlc_module_begin ()
> > set_category( CAT_AUDIO )
> > set_subcategory( SUBCAT_AUDIO_AFILTER )
> >
> >- add_obsolete_string( CFG_PREFIX "address" ) /* since 2.2.0 */
> >- add_obsolete_integer( CFG_PREFIX "port" ) /* since 2.2.0 */
> >add_integer( CFG_PREFIX "bargraph", 1, BARGRAPH_TEXT,
> >BARGRAPH_LONGTEXT, false ) // FIXME: this is a bool
> >add_integer( CFG_PREFIX "bargraph_repetition", 4,
> >BARGRAPH_REPETITION_TEXT, BARGRAPH_REPETITION_LONGTEXT, false )
> >add_integer( CFG_PREFIX "silence", 1, SILENCE_TEXT, SILENCE_LONGTEXT,
> >false ) // FIXME: this is a bool
> >add_integer( CFG_PREFIX "time_window", 5000, TIME_WINDOW_TEXT,
> >TIME_WINDOW_LONGTEXT, false )
> >add_float( CFG_PREFIX "alarm_threshold", 0.02, ALARM_THRESHOLD_TEXT,
> >ALARM_THRESHOLD_LONGTEXT, false )
> >add_integer( CFG_PREFIX "repetition_time", 2000, REPETITION_TIME_TEXT,
> >REPETITION_TIME_LONGTEXT, false )
> >- add_obsolete_integer( CFG_PREFIX "connection_reset" ) /* since
> >2.2.0 */
> >
> > set_callbacks( Open, Close )
> > vlc_module_end ()
> >diff --git a/modules/demux/mpeg/ts.c b/modules/demux/mpeg/ts.c
> >index b772292aa1..f31b57bb12 100644
> >--- a/modules/demux/mpeg/ts.c
> >+++ b/modules/demux/mpeg/ts.c
> >@@ -146,8 +146,6 @@ vlc_module_begin ()
> > change_safe()
> > add_bool( "ts-es-id-pid", true, PID_TEXT, PID_LONGTEXT, true )
> > change_safe()
> >- add_obsolete_string( "ts-out" ) /* since 2.2.0 */
> >- add_obsolete_integer( "ts-out-mtu" ) /* since 2.2.0 */
> > add_string( "ts-csa-ck", NULL, CSA_TEXT, CSA_LONGTEXT, true )
> > change_safe()
> > add_string( "ts-csa2-ck", NULL, CSA2_TEXT, CSA2_LONGTEXT, true )
> >diff --git a/modules/spu/audiobargraph_v.c
> >b/modules/spu/audiobargraph_v.c
> >index 858fcf5e45..37d91b6ce1 100644
> >--- a/modules/spu/audiobargraph_v.c
> >+++ b/modules/spu/audiobargraph_v.c
> >@@ -80,14 +80,12 @@ vlc_module_begin ()
> > set_shortname(N_("Audio Bar Graph Video"))
> > add_shortcut("audiobargraph_v")
> >
> >- add_obsolete_string(CFG_PREFIX "i_values") /* since 2.2.0 */
> > add_integer(CFG_PREFIX "x", 0, POSX_TEXT, POSX_LONGTEXT, true)
> > add_integer(CFG_PREFIX "y", 0, POSY_TEXT, POSY_LONGTEXT, true)
> > add_integer_with_range(CFG_PREFIX "transparency", 255, 0, 255,
> > TRANS_TEXT, TRANS_LONGTEXT, false)
> > add_integer(CFG_PREFIX "position", -1, POS_TEXT, POS_LONGTEXT, false)
> > change_integer_list(pi_pos_values, ppsz_pos_descriptions)
> >- add_obsolete_integer(CFG_PREFIX "alarm") /* since 2.2.0 */
> >add_integer(CFG_PREFIX "barWidth", 10, BARWIDTH_TEXT,
> >BARWIDTH_LONGTEXT, true)
> >add_integer(CFG_PREFIX "barHeight", 400, BARHEIGHT_TEXT,
> >BARHEIGHT_LONGTEXT, true)
> >
> >diff --git a/modules/stream_out/transcode/transcode.c
> >b/modules/stream_out/transcode/transcode.c
> >index 019deadc47..a40973e058 100644
> >--- a/modules/stream_out/transcode/transcode.c
> >+++ b/modules/stream_out/transcode/transcode.c
> >@@ -160,7 +160,6 @@ vlc_module_begin ()
> > SCALE_LONGTEXT, false )
> > add_string( SOUT_CFG_PREFIX "fps", NULL, FPS_TEXT,
> > FPS_LONGTEXT, false )
> >- add_obsolete_bool( SOUT_CFG_PREFIX "hurry-up"); /* Since 2.2.0 */
> > add_bool( SOUT_CFG_PREFIX "deinterlace", false, DEINTERLACE_TEXT,
> > DEINTERLACE_LONGTEXT, false )
> > add_string( SOUT_CFG_PREFIX "deinterlace-module", "deinterlace",
> >@@ -193,7 +192,6 @@ vlc_module_begin ()
> > add_integer( SOUT_CFG_PREFIX "samplerate", 0, ARATE_TEXT,
> > ARATE_LONGTEXT, true )
> > change_integer_range( 0, 48000 )
> >- add_obsolete_bool( SOUT_CFG_PREFIX "audio-sync" ) /*Since 2.2.0 */
> > add_module_list(SOUT_CFG_PREFIX "afilter", "audio filter", NULL,
> > AFILTER_TEXT, AFILTER_LONGTEXT)
> >
> >diff --git a/modules/video_output/decklink.cpp
> >b/modules/video_output/decklink.cpp
> >index 8fd60f8b47..85ea608bd5 100644
> >--- a/modules/video_output/decklink.cpp
> >+++ b/modules/video_output/decklink.cpp
> >@@ -285,7 +285,6 @@ vlc_module_begin()
> > set_capability("audio output", 0)
> > set_callbacks (OpenAudio, CloseAudio)
> > set_section(N_("DeckLink Audio Options"), NULL)
> >- add_obsolete_string("audio-connection") /* since 2.2.0 */
> > add_integer(AUDIO_CFG_PREFIX "audio-rate", 48000,
> > RATE_TEXT, RATE_LONGTEXT, true)
> > add_integer(AUDIO_CFG_PREFIX "audio-channels", 2,
> >diff --git a/src/libvlc-module.c b/src/libvlc-module.c
> >index 83c2f88592..a5c86c0dc7 100644
> >--- a/src/libvlc-module.c
> >+++ b/src/libvlc-module.c
> >@@ -2132,7 +2132,6 @@ vlc_module_begin ()
> > add_integer( "fetch-art-threads", 1, FETCH_ART_THREADS_TEXT,
> > FETCH_ART_THREADS_LONGTEXT, false )
> >
> >- add_obsolete_integer( "album-art" ) /* since 2.2.0 */
> > add_bool( "metadata-network-access", false, METADATA_NETWORK_TEXT,
> > METADATA_NETWORK_TEXT, false )
> >
> >
> >_______________________________________________
> >vlc-devel mailing list
> >To unsubscribe or modify your subscription options:
> >https://mailman.videolan.org/listinfo/vlc-devel
>
> --
> Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
More information about the vlc-devel
mailing list