[vlc-devel] [PATCH] httpd: update activity time before processing timeout (#25151)

[Rémi Denis-Courmont]

Hi,

Patched against stable branch should not only be clearly labeled as such but they also should explain why they don't relate to the development tree.

We don't want fixes going first, or worse, only, to stable branches.

Le 29 septembre 2020 10:49:47 GMT+03:00, Thomas Guillem <thomas at gllm.fr> a écrit :
>Missing a [VLC 3.0] prefix since it's a 3.0 patch, that is why it
>doesn't apply...
>
>Could we work together on that critical chromecast issue?
>
>On Mon, Sep 28, 2020, at 20:24, Rémi Denis-Courmont wrote:
>> Le maanantaina 28. syyskuuta 2020, 21.13.37 EEST Francois Cartegnie a
>écrit :
>> > Le 28/09/2020 à 19:57, Rémi Denis-Courmont a écrit :
>> > > Leaving aside that it does not apply, it does not look it solves
>much
>> > > anything. AFAIU, it just means that the socket will (now) or
>won't (with
>> > > the patch) be expired if the inactivity time-out exactly
>inherently races
>> > > with client activity. It's totally arbitrary and pretty much
>irrelevant
>> > > whether to process expiration or refresh first.
>> > > 
>> > > If it seems to work around a bug, then probably one of the above
>> > > supposedly
>> > > non-blocking client I/O functions is incorrectly blocking, and
>jamming the
>> > > whole server thread.
>> > 
>> > That's chromecast, there's a single connection.
>> 
>> No? There's nothing about Chromecast here. It's the HTTPd thread loop
>that 
>> handles all connections from all clients on a given HTTP/HTTPS/RTSP
>port. It 
>> could be Chromecast, it could be the HTTP interface, or both, or some
>other 
>> stream output.
>> 
>> And I somewhat doubt that Chromecast even guarantees a single
>connection per 
>> device.
>> 
>> -- 
>> Rémi Denis-Courmont
>> http://www.remlab.net/
>> 
>> 
>> 
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
>_______________________________________________
>vlc-devel mailing list
>To unsubscribe or modify your subscription options:
>https://mailman.videolan.org/listinfo/vlc-devel

-- 
Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20200929/8067c57c/attachment.html>