[vlc-devel] [PATCH 1/3] stream_ReadLine: don't close iconv handle on error

[Rémi Denis-Courmont]

Le keskiviikkona 30. syyskuuta 2020, 7.14.16 EEST Pierre Ynard via vlc-devel a 
écrit :
> > We should reset it for the corner case that it's interrupted on a lone
> > surrogate. Is that what you mean?
> 
> I don't understand your email. I had never heard about lone surrogates
> before you mentioned them, and I'm still not sure I understand them
> correctly. I don't think that's what I meant.

If it's not that, then I don't understand what error you are trying to handle.

AFAIK, the only other possible non-initial state would be a missing byte to 
form a codepoint. That should only be possible at EOF.

Either way, I think the correct error action is to reset the converter, not to 
keep it as is (nor to delete it as the current code does).

-- 
Реми Дёни-Курмон
http://www.remlab.net/