[vlc-devel] [PATCH 1/4] es_out: fix flapping PREROLL flag on non dated packets

[Rémi Denis-Courmont]

Le keskiviikkona 30. syyskuuta 2020, 20.47.26 EEST Francois Cartegnie a écrit 
:
> Le 30/09/2020 à 18:25, Rémi Denis-Courmont a écrit :
> > Le keskiviikkona 30. syyskuuta 2020, 18.44.04 EEST Francois Cartegnie a
> > écrit> 
> >> Saves pts to perform preroll target comparison against.
> >> refs #25129
> >> 
> >> In some cases, the packets are sent interleaved with non dated packets
> >> SEND 1
> >> SEND 0
> > 
> > I'm not a PCR expert, and Denis should probably cross-check this.
> > 
> > I don't really get how you can even hope to interpolate PTS if packets are
> > not sent in monotonic (increasing PTS) order? So it sounds like the
> > demuxer is
> That's monotonic. 0 is non-set values.

OK. The description is very confusing then.

> > broken beyond what the core can work around, and the demuxer needs fixing
> > here?
> We are sending non dated from demuxers since always.
> Some packetizer do care about interpolation.

With time-ordered packets, sure.

-- 
Rémi Denis-Courmont
http://www.remlab.net/