[vlc-devel] [PATCH 2/2] block: do not allow negative discard values in blocks

Rémi Denis-Courmont remi at remlab.net
Sat Apr 3 07:59:47 UTC 2021


Prepending has been used in the past and there are no obvious reasons why it 
wouldn't be anymore in the future. And then if it has been removed, we end up 
with more memory copying.

Given that this is actually tested automatically, there are no reasons to 
remove it.


> This feature is never used and negative ssize_t is supposed to be only -1:

That's not true. And that's *not* what this quote says:

>  The type ssize_t is capable of storing values at least in the range
> [-1, SSIZE_MAX]

In other words, it supports -SSIZE_MAX to SSIZE_MAX with one-complement and 
sign-magniture representation, or -(SSIZE_MAX + 1) to SSIZE_MAX with two-
complement representation.

Реми Дёни-Курмон

More information about the vlc-devel mailing list