[vlc-devel] [PATCH v2 1/7] clock: handle the normal play time (npt) from the input

[Thomas Guillem]

On Sat, Apr 3, 2021, at 10:22, Rémi Denis-Courmont wrote:
> Le torstaina 1. huhtikuuta 2021, 18.30.06 EEST Thomas Guillem a écrit :
> > vlc_clock_t will send corrected update points directly.
> > 
> > The player won't have to fetch the normal_time from the demux and fix
> > its timer accordingly.
> 
> I'm not convinced that the clock should know/care about NPT.

The clock doesn't use it for any calculation. It is just used when passing the pts/system_date points to the clock listener (the player) and only for information purpose.

> 
> And if we need to track NPT per group, that seems rather problematic, because 
> there will be multiple NPTs for a single clock...

Yes, NPT are per group, but there is also one vlc_clock_main per group, so if there are multiple NPTs, they will be handled by their respective clock (main).

> 
> -- 
> 雷米‧德尼-库尔蒙
> http://www.remlab.net/
> 
> 
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel