[vlc-devel] [VLC 3.x 2/2] codec: dav1d: do not use VLC_CLIP

Steve Lhomme robux4 at ycbcr.xyz
Wed Apr 7 09:01:20 UTC 2021


On 2021-04-07 9:55, Rémi Denis-Courmont wrote:
> You don't get to "disagree" with the trivially provable *fact* that this 
> macro is not expansion-safe.

I disagreed with "it's a poor excuse of a functional macro" and 
explained why. Pay more attention to what is written.

> And replacing 3 *trivial* lines with one proprietary macro is not a good 
> thing.
> 
> Le 7 avril 2021 08:29:21 GMT+03:00, Steve Lhomme <robux4 at ycbcr.xyz> a 
> écrit :
> 
>     On 2021-04-06 16:25, Rémi Denis-Courmont wrote:
> 
>         Le tiistaina 6. huhtikuuta 2021, 17.07.01 EEST Steve Lhomme a
>         écrit :
> 
>             Why ?
> 
>         Because it's a poor excuse of a functional macro that is not
>         expansion-safe,
>         and whose behaviour is utterly trivial.
> 
> 
>     I disagree. This is the perfect use case for it. And replacing a one
>     liner by 3 lines is never good in my book.
>     ------------------------------------------------------------------------
>     vlc-devel mailing list
>     To unsubscribe or modify your subscription options:
>     https://mailman.videolan.org/listinfo/vlc-devel  <https://mailman.videolan.org/listinfo/vlc-devel>
> 
> 
> -- 
> Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser 
> ma brièveté.
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
> 


More information about the vlc-devel mailing list