[vlc-devel] [PATCH v4 0/8] Add the input clock as a clock source

Thomas Guillem thomas at gllm.fr
Wed Apr 7 09:11:19 UTC 2021


Hello,

So, OK with this patch set?

On Thu, Apr 1, 2021, at 16:00, Thomas Guillem wrote:
> Hello,
> 
> Changes since v3:
> 
> The main_clock is not "hacked" anymore. The input drift is handled by
> using the input_clock_t as a clock source and it won't be enabled by
> default like in my very first proposal.
> 
> The last commit need special attention: do we want to enable the
> input_clock by default for all non paced inputs ? If not, this last
> commit should not be pushed. I personally prefer to use the auto mode by
> default.
> 
> Please, also review "core: add a detailed description for the
> clock-master option", are you OK with the 4 description I have written ?
> 
> Best regards,
> Thomas Guillem (9):
>   core: change the "--clock-master" type to string
>   core: add a detailed description for the clock-master option
>   es_out: refactor clock_source cat selection
>   input_clock: add the ability to drive the main_clock
>   es_out: change clocks allocation order
>   es_out: constify p_master_clock
>   core: add the "input" clock source
>   core: add the "auto" clock source
>   core: use "auto" as the default clock-master source
> 
>  src/clock/clock.h       |   5 +-
>  src/clock/input_clock.c |  35 ++++++++++++-
>  src/clock/input_clock.h |   7 ++-
>  src/input/es_out.c      | 109 +++++++++++++++++++++++++++++++++-------
>  src/libvlc-module.c     |  19 ++++---
>  5 files changed, 145 insertions(+), 30 deletions(-)
> 
> -- 
> 2.30.0
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel


More information about the vlc-devel mailing list