[vlc-devel] [PATCH v2 2/7] es_out: add ES_OUT_SET_NPT

[Thomas Guillem]

On Sat, Apr 3, 2021, at 10:24, Rémi Denis-Courmont wrote:
> Le torstaina 1. huhtikuuta 2021, 18.30.07 EEST Thomas Guillem a écrit :
> > This will replace DEMUX_GET_NORMAL_TIME.
> > 
> > Demux modules should set a valid normal play time if the PCR and the
> > time reported by DEMUX_GET_TIME don't have the same origin. This is the
> > case for mpeg/ts, dvd, bluray, cdda, adaptive.
> 
> NPT is the time that is intrinsically the time visible to the user. And that's 
> also what DEMUX_GET_TIME is supposed to be. We can't have both. It makes no 
> sense now, and it won't make sense with this.
> 
> (I agree that an event makes more sense than a control though.)

NPT can't replace DEMUX_GET_TIME. DEMUX_GET_TIME can return a valid time even if the demux fail to parse any program/ES/PTS. This control is used from the player, as a last resort, to get the time.

Ideally, we should replace DEMUX_GET_TIME (and POSITION) with events but patching every demuxers will be quite time-consuming and could lead to possible regressions.

That is why I don't really want to touch DEMUX_GET_TIME and DEMUX_GET_POSITION for now.

So, it's either DEMUX_GET_NORMAL_TIME or ES_OUT_SET_NPT, leaving DEMUX_GET_TIME(POSITION) (for now.

> 
> -- 
> 雷米‧德尼-库尔蒙
> http://www.remlab.net/
> 
> 
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel