[vlc-devel] [PATCH v2 2/7] es_out: add ES_OUT_SET_NPT

[Thomas Guillem]

On Wed, Apr 7, 2021, at 16:51, Rémi Denis-Courmont wrote:
> Le keskiviikkona 7. huhtikuuta 2021, 16.59.33 EEST Thomas Guillem a écrit :
> > On Sat, Apr 3, 2021, at 10:24, Rémi Denis-Courmont wrote:
> > > Le torstaina 1. huhtikuuta 2021, 18.30.07 EEST Thomas Guillem a écrit :
> > > > This will replace DEMUX_GET_NORMAL_TIME.
> > > > 
> > > > Demux modules should set a valid normal play time if the PCR and the
> > > > time reported by DEMUX_GET_TIME don't have the same origin. This is the
> > > > case for mpeg/ts, dvd, bluray, cdda, adaptive.
> > > 
> > > NPT is the time that is intrinsically the time visible to the user. And
> > > that's also what DEMUX_GET_TIME is supposed to be. We can't have both. It
> > > makes no sense now, and it won't make sense with this.
> > > 
> > > (I agree that an event makes more sense than a control though.)
> > 
> > NPT can't replace DEMUX_GET_TIME.
> 
> I have to disagree. By definition, they're literally the exact same thing.
> 
> -1

OK, I will leave that for VLC 5.0 then.

I will send patches fixing DEMUX_GET_NORMAL_TIME for TS.

> 
> -- 
> 雷米‧德尼-库尔蒙
> http://www.remlab.net/
> 
> 
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel