[vlc-devel] [PATCH 1/7] qml: fix binding loop detected warning in PlaylistToolbar

Fatih Uzunoglu fuzun54 at outlook.com
Sun Apr 11 21:45:26 UTC 2021


fixes part of #25601
---
 modules/gui/qt/playlist/qml/PlaylistToolbar.qml | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/modules/gui/qt/playlist/qml/PlaylistToolbar.qml b/modules/gui/qt/playlist/qml/PlaylistToolbar.qml
index ca0f52418b..3c0a7201e4 100644
--- a/modules/gui/qt/playlist/qml/PlaylistToolbar.qml
+++ b/modules/gui/qt/playlist/qml/PlaylistToolbar.qml
@@ -34,7 +34,7 @@ RowLayout {
 
     Item {
         Layout.fillWidth: true
-        implicitHeight: childrenRect.height
+        implicitHeight: loop.height
 
         Widgets.IconToolButton {
             id: loop
@@ -54,7 +54,7 @@ RowLayout {
 
     Item {
         Layout.fillWidth: true
-        implicitHeight: childrenRect.height
+        implicitHeight: shuffle.height
 
         Widgets.IconToolButton {
             id: shuffle
@@ -71,7 +71,7 @@ RowLayout {
 
     Item {
         Layout.fillWidth: true
-        implicitHeight: childrenRect.height
+        implicitHeight: sort.height
 
         Widgets.SortControl {
             id: sort
@@ -117,7 +117,7 @@ RowLayout {
 
     Item {
         Layout.fillWidth: true
-        implicitHeight: childrenRect.height
+        implicitHeight: clear.height
 
         Widgets.IconToolButton {
             id: clear
-- 
2.27.0



More information about the vlc-devel mailing list