[vlc-devel] [PATCH v4 2/9] core: add a detailed description for the clock-master option

[Thomas Guillem]

On Sun, Apr 4, 2021, at 11:41, Rémi Denis-Courmont wrote:
> Le torstaina 1. huhtikuuta 2021, 17.00.25 EEST Thomas Guillem a écrit :
> > ---
> >  src/libvlc-module.c | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> > 
> > diff --git a/src/libvlc-module.c b/src/libvlc-module.c
> > index 94b6a644e5f..e073ee27eca 100644
> > --- a/src/libvlc-module.c
> > +++ b/src/libvlc-module.c
> > @@ -542,8 +542,9 @@ static const char *const ppsz_clock_master_values[] = {
> >      "audio", "monotonic",
> >  };
> >  static const char *const ppsz_clock_master_descriptions[] = {
> > -    N_("Audio"),
> > -    N_("Monotonic")
> > +    N_("If an audio track is playing, the audio output will drive the
> > clock" +        "(Fallback to Monotonic if there is no audio tracks)."),
> > +    N_("All tracks are driven by the monotonic clock of the system.")
> >  };
> 
> Err, these are supposed to be caption for the preference dialog, not info 
> bubbles. I don't think they can be that long without wrecking the layout one 
> way or the other. Ditto patches 7 and 8.

Indeed, I got mixed up with the LONGTEXT field.

> 
> > 
> >  static const int pi_clock_values[] = { -1, 0, 1 };
> 
> 
> -- 
> Rémi Denis-Courmont
> http://www.remlab.net/
> 
> 
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel