[vlc-devel] [PATCH] opengl: fix missing flag initialization

Romain Vimont rom1v at videolabs.io
Mon Apr 12 17:04:14 UTC 2021


The flag filter_planes was not explicitly initialized, and non-plane
filters assume that it is set to false by default.

It still worked because the filter happens to be initialized by calloc()
in the end, but we shouldn't rely on this detail (and the other fields
are also explicitly initialized).
---
 modules/video_output/opengl/filter.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/modules/video_output/opengl/filter.c b/modules/video_output/opengl/filter.c
index b7357c7b20..02ffc7d75d 100644
--- a/modules/video_output/opengl/filter.c
+++ b/modules/video_output/opengl/filter.c
@@ -49,6 +49,7 @@ vlc_gl_filter_New(vlc_object_t *parent, const struct vlc_gl_api *api)
 
     struct vlc_gl_filter *filter = &priv->filter;
     filter->api = api;
+    filter->config.filter_planes = false;
     filter->config.blend = false;
     filter->config.msaa_level = 0;
     filter->ops = NULL;
-- 
2.31.0



More information about the vlc-devel mailing list