[vlc-devel] [PATCH 12/17] vulkan: display: remove default vulkan name

[Alexandre Janniaux]

Hi

On Wed, Apr 14, 2021 at 11:55:12AM +0200, Romain Vimont wrote:
> On Mon, Apr 12, 2021 at 03:32:28PM +0200, Alexandre Janniaux wrote:
> > ---
> >  modules/video_output/vulkan/display.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/modules/video_output/vulkan/display.c b/modules/video_output/vulkan/display.c
> > index dc6cb2726c..4aaaad5f29 100644
> > --- a/modules/video_output/vulkan/display.c
> > +++ b/modules/video_output/vulkan/display.c
> > @@ -486,7 +486,7 @@ vlc_module_begin ()
> >      set_subcategory (SUBCAT_VIDEO_VOUT)
> >      set_callback_display(Open, 0)
> >      add_shortcut ("vulkan", "vk")
> > -    add_module ("vk", "vulkan", NULL, VK_TEXT, PROVIDER_LONGTEXT)
> > +    add_module ("vk", "", NULL, VK_TEXT, PROVIDER_LONGTEXT)
>
> It seems it's the only module in VLC with an empty string for
> capabilities:
>
>     $ rg 'add_module\s*\([^,]*,\s*""'
>     modules/video_output/vulkan/display.c
>     489:    add_module ("vk", "", NULL, VK_TEXT, PROVIDER_LONGTEXT)
>             ^^^^^^^^^^^^^^^^^^^^
>
> Isn't it odd?

This is not a strict loading, so "" means "any".

I can replace by NULL if you prefer, like in other cases:
src/libvlc-module.c:    add_string( "keystore", NULL, KEYSTORE_TEXT,

> >
> >      set_section("Scaling", NULL)
> >      add_integer("upscaler-preset", SCALE_BUILTIN,
> > --
> > 2.31.1
> >
> > _______________________________________________
> > vlc-devel mailing list
> > To unsubscribe or modify your subscription options:
> > https://mailman.videolan.org/listinfo/vlc-devel
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel