[vlc-devel] [PATCH 17/17] display: use osys->display_fmt directly

[Alexandre Janniaux]

Hi,

On Thu, Apr 15, 2021 at 08:33:42AM +0200, Steve Lhomme wrote:
> This patch doesn't seem related at all to the patchset so would have been
> better on its own.
>
> On 2021-04-12 15:32, Alexandre Janniaux wrote:
> > vd->fmt is a pointer for osys->display_fmt designed to be in the vout
> > display public interface. Instead, consistently use osys->display_fmt
> > which already is the pointed value.
>
> Yes, but there are still plenty of places where vd->fmt is used in that
> file. Why change just this one ?

I was investigating why the Vulkan display was crashing and
it was on the path.

Regards,
--
Alexandre Janniaux
Videolabs

> > ---
> >   src/video_output/display.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/src/video_output/display.c b/src/video_output/display.c
> > index ff665d2af5..5138b36218 100644
> > --- a/src/video_output/display.c
> > +++ b/src/video_output/display.c
> > @@ -323,7 +323,7 @@ static int VoutDisplayCreateRender(vout_display_t *vd)
> >       v_src.i_sar_num = 0;
> >       v_src.i_sar_den = 0;
> > -    video_format_t v_dst = *vd->fmt;
> > +    video_format_t v_dst = osys->display_fmt;
> >       v_dst.i_sar_num = 0;
> >       v_dst.i_sar_den = 0;
> > --
> > 2.31.1
> >
> > _______________________________________________
> > vlc-devel mailing list
> > To unsubscribe or modify your subscription options:
> > https://mailman.videolan.org/listinfo/vlc-devel
> >
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel