[vlc-devel] [PATCH] sd: remove -S/--services-discovery option

[Alexandre Janniaux]

Hi,

I'm against the removal of this option, since the Qt interface
is not supposed to be the only way to test this option, and
starting every service discovery on start when you never use
them is quite wasteful. Said otherwise, it has been made
meaningless but is not supposed to be useless.

But anyway, regardless of whether we want to remove it or not,
removing an option that was used on commandline will break
commandline. The way to go is using the add_obsolete_*
variants.

Regards,
--
Alexandre Janniaux
Videolabs

On Thu, Apr 15, 2021 at 03:22:48PM +0200, Romain Vimont wrote:
> In the old playlist, services discoveries were added as special nodes,
> child of the root playlist node. The option -S/--services-discovery
> gave the possibility to add some of these services discoveries nodes to
> the playlist on start.
>
> Now, all the media sources are available via the media source
> API. There are listed in the Qt views (depending on their category).
>
> As a consequence, this option is now meaningless. Remove it.
>
> Fixes #24592
> ---
>  src/libvlc-module.c | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/src/libvlc-module.c b/src/libvlc-module.c
> index 8050b2eea1..a569f41b62 100644
> --- a/src/libvlc-module.c
> +++ b/src/libvlc-module.c
> @@ -2206,10 +2206,6 @@ vlc_module_begin ()
>                "Flatten files listed by extractors (archive)", NULL, true )
>          change_volatile()
>
> -    set_subcategory( SUBCAT_PLAYLIST_SD )
> -    add_string( "services-discovery", "", SD_TEXT, SD_LONGTEXT, true )
> -        change_short('S')
> -
>  /* Interface options */
>      set_category( CAT_INTERFACE )
>      set_subcategory( SUBCAT_INTERFACE_GENERAL )
> --
> 2.31.0
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel