[vlc-devel] [PATCH] sd: remove -S/--services-discovery option

Alexandre Janniaux ajanni at videolabs.io
Sat Apr 17 10:31:24 UTC 2021


On Fri, Apr 16, 2021 at 02:58:01PM +0200, Romain Vimont wrote:
> Loading a media source returns a refcounted instance: the SD will only
> be opened on the first client and closed on the last client. The purpose
> is to let several interfaces open their own services discoveries without
> opening several time the same SD (which would be a waste of resources,
> including network requests, etc.).

Let aside the current subject in this thread, I don't think
that media source should be refcounted by the core, ie.
implementations/modules should refcount themselves as needed.

There are not much implication right now, since it's just a
shift of the refcount, but it has a lot if service discovery
is to be exposed to the libvlc API some day, since libvlc
can only refcount at the libvlc level, and thus different
libvlc instances will lead to different service discovery
being loaded, and libvlc cannot store the state itself since
the service discovery will expect to live in a valid libvlc

That's just thoughts I just had, so nothing linked to the
discussion here though.

Alexandre Janniaux

More information about the vlc-devel mailing list